feat: Added CoursewareSearchResults UI component #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1224 +/- ##
==========================================
- Coverage 88.19% 88.18% -0.02%
==========================================
Files 271 273 +2
Lines 4591 4620 +29
Branches 1151 1164 +13
==========================================
+ Hits 4049 4074 +25
- Misses 528 531 +3
- Partials 14 15 +1
☔ View full report in Codecov by Sentry. |
rijuma
force-pushed
the
rijuma/courseware-search-results-ui
branch
from
71cc670 to
7712a78
Compare
|
This is a UI component with mocked behavior for testing. I don't think this needs to have coverage atm. It will be wrapped up in an implementation ticket. |
aethant
reviewed
Oct 25, 2023
aethant
reviewed
Oct 25, 2023
aethant
reviewed
Oct 25, 2023
aethant
approved these changes
Oct 25, 2023
CefBoud
pushed a commit
to open-craft/frontend-app-learning
that referenced
this pull request
Nov 5, 2023
* feat: Added CoursewareSearchResults UI component * fix: Added conditional for undefined case instead of null * fix: Updated code to avoid mutation
CefBoud
pushed a commit
to open-craft/frontend-app-learning
that referenced
this pull request
Nov 6, 2023
* feat: Added CoursewareSearchResults UI component * fix: Added conditional for undefined case instead of null * fix: Updated code to avoid mutation
CefBoud
pushed a commit
to open-craft/frontend-app-learning
that referenced
this pull request
Nov 6, 2023
* feat: Added CoursewareSearchResults UI component * fix: Added conditional for undefined case instead of null * fix: Updated code to avoid mutation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket: KBK-44 🔒
We need a Search Results UI component 🔒 to show the search components and the results.
UI changes
Showing results
No results
Testing Instructions:
This shows mocked results, so in order to see the variations:
lorem ipsumwill show the "no results" variant.lorem ipsumwill show a fixed number of results.