Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KBK-51] Clear search results when search field is cleared #1231

Closed
wants to merge 1 commit into from

Conversation

aethant
Copy link
Contributor

@aethant aethant commented Oct 31, 2023

KBK-51

As a user, I expect that when I clear the search input, the filter will disappear and no content will be presented.

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ce24a58) 88.20% compared to head (316eb97) 88.18%.
Report is 1 commits behind head on master.

❗ Current head 316eb97 differs from pull request most recent head 66f01d3. Consider uploading reports for the commit 66f01d3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1231      +/-   ##
==========================================
- Coverage   88.20%   88.18%   -0.02%     
==========================================
  Files         274      274              
  Lines        4628     4630       +2     
  Branches     1165     1166       +1     
==========================================
+ Hits         4082     4083       +1     
- Misses        532      533       +1     
  Partials       14       14              
Files Coverage Δ
...course-home/courseware-search/CoursewareSearch.jsx 68.75% <50.00%> (-2.68%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schenedx
Copy link
Contributor

This person no longer works for 2U. Closing the PR.

@schenedx schenedx closed this Dec 12, 2023
@schenedx schenedx deleted the clear-search branch December 12, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants