Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: forward modal-close event to children on modal close #1238

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

muselesscreator
Copy link
Contributor

This allows children that prompt the opening of a modal with plugin.modal to receive plugin.modal-close event when the modal closes.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (62465ec) 88.09% compared to head (8927e6e) 87.48%.
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1238      +/-   ##
==========================================
- Coverage   88.09%   87.48%   -0.62%     
==========================================
  Files         268      275       +7     
  Lines        4537     4729     +192     
  Branches     1145     1195      +50     
==========================================
+ Hits         3997     4137     +140     
- Misses        526      575      +49     
- Partials       14       17       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muselesscreator muselesscreator merged commit fe773d1 into master Nov 21, 2023
4 of 5 checks passed
@muselesscreator muselesscreator deleted the feat/ora-integration branch November 21, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants