Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage for Courseware Search components #1242

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Add test coverage for Courseware Search components #1242

merged 3 commits into from
Dec 4, 2023

Conversation

rijuma
Copy link
Member

@rijuma rijuma commented Nov 28, 2023 •
edited
Loading

Added coverage:

src/course-home/courseware-search                            |   99.34 |    97.22 |     100 |     100 |
  CoursewareResultsFilter.jsx                                |     100 |      100 |     100 |     100 |
  CoursewareSearch.jsx                                       |     100 |      100 |     100 |     100 |
  CoursewareSearchEmpty.jsx                                  |     100 |      100 |     100 |     100 |
  CoursewareSearchForm.jsx                                   |     100 |      100 |     100 |     100 |
  CoursewareSearchResults.jsx                                |     100 |      100 |     100 |     100 |
  CoursewareSearchToggle.jsx                                 |     100 |      100 |     100 |     100 |
  hooks.js                                                   |     100 |      100 |     100 |     100 |
  index.js                                                   |       0 |        0 |       0 |       0 |
  map-search-response.js                                     |   97.22 |     90.9 |     100 |     100 | 55,82
  messages.js                                                |     100 |      100 |     100 |     100 |

@rijuma rijuma force-pushed the rijuma/courseware-search-tests branch from ab5453c to 824032d Compare November 29, 2023 13:12
@codecov Codecov
Copy link

codecov bot commented Nov 29, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bce25c4) 87.30% compared to head (967c13d) 87.92%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1242      +/-   ##
==========================================
+ Coverage   87.30%   87.92%   +0.62%     
==========================================
  Files         275      276       +1     
  Lines        4717     4721       +4     
  Branches     1190     1191       +1     
==========================================
+ Hits         4118     4151      +33     
+ Misses        580      554      -26     
+ Partials       19       16       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rijuma rijuma force-pushed the rijuma/courseware-search-tests branch from a9db775 to 967c13d Compare December 1, 2023 16:16
@rijuma rijuma marked this pull request as ready for review December 1, 2023 16:31
schenedx
schenedx approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@schenedx schenedx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rijuma rijuma merged commit 5906576 into master Dec 4, 2023
6 checks passed
@rijuma rijuma deleted the rijuma/courseware-search-tests branch December 4, 2023 15:39
@rijuma rijuma changed the title Add test coverage for Courseware Search components (WIP) Add test coverage for Courseware Search components Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schenedx schenedx schenedx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rijuma @schenedx