-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use state params to keep query and filter while searching #1249
feat: use state params to keep query and filter while searching #1249
Conversation
467c225
to
4392ec5
Compare
9e9fd10
to
2123419
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 2 NIT feedbacks for now. I hope you can merge this after tests are reviewed as well.
Thanks
Done ✅ |
de38476
to
e5937de
Compare
b4e2ca2
to
8550347
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1249 +/- ##
==========================================
+ Coverage 87.92% 88.01% +0.08%
==========================================
Files 276 276
Lines 4721 4739 +18
Branches 1192 1194 +2
==========================================
+ Hits 4151 4171 +20
+ Misses 554 552 -2
Partials 16 16 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
feat: use state params to keep query and filter while searching (openedx#1249)
Use
useSearchParams
to save query and filter selection while searching to be able to share the link and automatically perform the search action when enter on it.https://2u-internal.atlassian.net/browse/KBK-75