Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use state params to keep query and filter while searching #1249

Merged
merged 5 commits into from
Dec 11, 2023

Conversation

germanolleunlp
Copy link
Contributor

Use useSearchParams to save query and filter selection while searching to be able to share the link and automatically perform the search action when enter on it.

https://2u-internal.atlassian.net/browse/KBK-75

@germanolleunlp germanolleunlp force-pushed the go/kbk-75-aria-update-behavioral-changes branch from 467c225 to 4392ec5 Compare December 5, 2023 13:28
@germanolleunlp germanolleunlp requested a review from rijuma December 5, 2023 13:29
@germanolleunlp germanolleunlp force-pushed the go/kbk-75-aria-update-behavioral-changes branch 3 times, most recently from 9e9fd10 to 2123419 Compare December 5, 2023 14:14
Copy link
Contributor

@schenedx schenedx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 NIT feedbacks for now. I hope you can merge this after tests are reviewed as well.
Thanks

src/course-home/courseware-search/CoursewareSearch.jsx Outdated Show resolved Hide resolved
@germanolleunlp
Copy link
Contributor Author

Just 2 NIT feedbacks for now. I hope you can merge this after tests are reviewed as well. Thanks

Done ✅

@germanolleunlp germanolleunlp force-pushed the go/kbk-75-aria-update-behavioral-changes branch 2 times, most recently from de38476 to e5937de Compare December 5, 2023 17:08
@germanolleunlp germanolleunlp force-pushed the go/kbk-75-aria-update-behavioral-changes branch from b4e2ca2 to 8550347 Compare December 11, 2023 12:59
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d065c23) 87.92% compared to head (8550347) 88.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1249      +/-   ##
==========================================
+ Coverage   87.92%   88.01%   +0.08%     
==========================================
  Files         276      276              
  Lines        4721     4739      +18     
  Branches     1192     1194       +2     
==========================================
+ Hits         4151     4171      +20     
+ Misses        554      552       -2     
  Partials       16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rijuma rijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@germanolleunlp germanolleunlp merged commit 4d72333 into master Dec 11, 2023
6 checks passed
@germanolleunlp germanolleunlp deleted the go/kbk-75-aria-update-behavioral-changes branch December 11, 2023 13:45
LauraFgar added a commit to LauraFgar/frontend-app-learning that referenced this pull request Dec 11, 2023
feat: use state params to keep query and filter while searching (openedx#1249)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants