Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove segment event #1250

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

alangsto
Copy link
Contributor

@alangsto alangsto commented Dec 5, 2023

COSMO-9

With the end of our first experiment related to the learning assistant experience, the Cosmonauts team would also like to remove a segment event logged for each render of the chat component. This segment was added for both experimental and diagnostic purposes, so with the end of the experiment, this is no longer needed.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a30dccd) 87.93% compared to head (156b0d6) 87.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1250      +/-   ##
==========================================
- Coverage   87.93%   87.92%   -0.01%     
==========================================
  Files         276      276              
  Lines        4723     4721       -2     
  Branches     1193     1192       -1     
==========================================
- Hits         4153     4151       -2     
  Misses        554      554              
  Partials       16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@varshamenon4 varshamenon4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@alangsto alangsto merged commit 83c6007 into master Dec 5, 2023
6 checks passed
@alangsto alangsto deleted the alangsto/remove_segment_event branch December 5, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants