fix: prevent error when there are no results for a given filter #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schenedx
approved these changes
Dec 19, 2023
| @@ -15,7 +15,7 @@ const iconTypeMapping = { | |||
|
|
|||
| const defaultIcon = Article; | |||
|
|
|||
| const CoursewareSearchResults = ({ results }) => { | |||
| const CoursewareSearchResults = ({ results = [] }) => { | |||
There was a problem hiding this comment.
Could we develop a test case for this?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1257 +/- ##
=======================================
Coverage 87.97% 87.98%
=======================================
Files 276 276
Lines 4742 4745 +3
Branches 1193 1197 +4
=======================================
+ Hits 4172 4175 +3
Misses 554 554
Partials 16 16 ☔ View full report in Codecov by Sentry. |
germanolleunlp
force-pushed
the
KBK-79-understandable-result-section-naming-for-learners
branch
from
ebff1e8 to
fbdef5f
Compare
germanolleunlp
deleted the
KBK-79-understandable-result-section-naming-for-learners
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://2u-internal.atlassian.net/browse/KBK-79