-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidebar navigation takes over half the width of the page when Indigo theme is used #1401
Comments
FYI @arbrandes @brian-smith-tcril @openedx/2u-infinity, please tag anyone you think can help. Thanks! |
@GlugovGrGlib - curious about the effort level for this fix? The experience navigating course content in indigo is more clunky with the course content view so narrow (see screenshot above). It's not a release blocker, and because this isn't the default experience, I didn't mark it as high priority, but resolving this ahead of release (if possible) would be a huge win for this feature (I'd prioritize it second in the sidebar bugs - below #1013). |
@brian-smith-tcril - Curious if it's possible to easily tell if this is a quick and simple fix or maybe something deeper? |
Considering this is an issue on the indigo theme and not on the Open edX theme, it would need to be addressed there. Since this is in an MFE, it would need to be addressed in the indigo fork of The As of writing, that is version This appears to have been published from the The issue appears to be this line https://github.com/edly-io/brand-openedx/blob/0622d6a6bdf1f5ba84bfaf6cd4d18133a4b3b57d/paragon/_overrides.scss#L14 .container-xl {
max-width: 1090px !important; With that removed I see However, simply removing that line will change a lot of things globally. I don't expect that change to be something indigo maintainers would be happy with, and I'm not sure what it would take to address this in a less far-reaching way. |
@brian-smith-tcril - Thanks for this insight, Brian. Not excited about the result, but this input will help me make some calls. Thank you! |
Hi @crathbun428 @mariajgrimaldi, we should move this issue to https://github.com/overhangio/tutor-indigo/ repository, so the indigo theme maintainer will address and take decision about theme redesign |
The new issue was created in the tutor-indigo repository: overhangio/tutor-indigo#83 |
@GlugovGrGlib - Thank you! This makes sense to me. My plan is to figure out if there is an appropriate product contact I can chat with about this issue, too. Thank you for creating this issue in the indigo theme repository. |
@crathbun428 Good news! Edly just resolved this issue today - overhangio/tutor-indigo#83 |
@GlugovGrGlib - Amazing! This is such good news - thank you for the head's up!! |
Fixed by overhangio/tutor-indigo#85 |
Steps to Reproduce
Expected Behavior
Expected Behavior
The text was updated successfully, but these errors were encountered: