-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clock icon in courseware sidebar does not follow conventions for notifications #1509
Comments
@arbrandes |
Hello aphilipharrell, I already made the PR |
@crathbun428 Can you please check if this request can be implemented? We can do it if approved. |
@angonz - There is potentially going to be some work done on the right-sidebar soon. I think thinking through what icons are shown will be apart of this work. I want to check in with @brian-smith-tcril and @jmakowski1123 to make sure I have this right. |
Hi @aphilipharrell, just a heads-up that we ended up closing #1510 because it looked like someone had already made the same changes for Sumac. So you might want to consider closing this issue, too. |
The clock icon in the courseware sidebar leads to a Notifications window - the clock icon is misleading and this should be replaced with something more commonly understood to represent notifications.
Suggested fix:
Replace
WatchOutline
withNotifications
in src/courseware/course/sidebar/sidebars/notifications/NotificationIcon.jsxThe text was updated successfully, but these errors were encountered: