Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace @edx/paragon and @edx/frontend-build #945

Merged
merged 4 commits into from
Feb 22, 2024

Conversation

Mashal-m
Copy link
Contributor

Part of openedx/axim-engineering#23

This replaces the @edx/paragon and @edx/frontend-build package.
Imports have been updated to use the same locations in the new package.

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (761995b) 66.82% compared to head (bd4b79b) 66.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #945   +/-   ##
=======================================
  Coverage   66.82%   66.82%           
=======================================
  Files          52       52           
  Lines         850      850           
  Branches      176      176           
=======================================
  Hits          568      568           
  Misses        272      272           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsnwesson
Copy link
Contributor

Hey @BilalQamar95 and @Mashal-m , just wanted to check in on this PR since it is marked "ready for review"! Who is planned for a code review: AXIM, another eng in Fed-BOM, or an eng in Aperture? This question applies to all of Aperture's MFEs as well (Learner-Dashboard, Learner-Record, Skills). Thanks!

@BilalQamar95
Copy link
Contributor

Hi @jsnwesson, generally such PRs are planned to be reviewed by owning squad (aperture in this case). In cases where its someone other than the owning squad we tend to tag them as reviewers. Hope this helps

@jsnwesson jsnwesson added waiting for eng review PR is ready for review. Review and merge it, or suggest changes. needs maintainer attention Issue or PR specifically needs the attention of the maintainer. labels Feb 16, 2024
@jsnwesson
Copy link
Contributor

@BilalQamar95 thanks for clarifying! I'll be adding a couple of labels to make it clear that this is ready for review.

Copy link
Contributor

@jsnwesson jsnwesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran it locally and looks good to me!

@jsnwesson
Copy link
Contributor

Ah, looks like there is a package-lock conflict @BilalQamar95 . once that's resolved, I can merge and deploy the PR!

@jsnwesson jsnwesson added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Feb 16, 2024
@BilalQamar95
Copy link
Contributor

Hi @jsnwesson, I have resolved the conflicts

@jsnwesson jsnwesson removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Feb 22, 2024
@jsnwesson jsnwesson merged commit 676166a into master Feb 22, 2024
9 checks passed
@jsnwesson jsnwesson deleted the mashal-m/replace-edx/paragon-frontend-build branch February 22, 2024 17:21
@BilalQamar95 BilalQamar95 self-assigned this Feb 23, 2024
@OmarIthawi
Copy link
Member

OmarIthawi commented Feb 27, 2024

@BilalQamar95 @jsnwesson this pull request removed the openedx-atlas package which is needed for translations:

As far as I can see this was an intentional. I'll open another pull request to get the required package back. Please don't remove, otherwise Tutor MFE builds will be broken.

Fix:

@BilalQamar95 BilalQamar95 restored the mashal-m/replace-edx/paragon-frontend-build branch April 23, 2024 11:44
@BilalQamar95 BilalQamar95 deleted the mashal-m/replace-edx/paragon-frontend-build branch April 23, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs maintainer attention Issue or PR specifically needs the attention of the maintainer. waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants