-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace @edx/paragon and @edx/frontend-build #945
refactor: replace @edx/paragon and @edx/frontend-build #945
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #945 +/- ##
=======================================
Coverage 66.82% 66.82%
=======================================
Files 52 52
Lines 850 850
Branches 176 176
=======================================
Hits 568 568
Misses 272 272
Partials 10 10 ☔ View full report in Codecov by Sentry. |
Hey @BilalQamar95 and @Mashal-m , just wanted to check in on this PR since it is marked "ready for review"! Who is planned for a code review: AXIM, another eng in Fed-BOM, or an eng in Aperture? This question applies to all of Aperture's MFEs as well (Learner-Dashboard, Learner-Record, Skills). Thanks! |
Hi @jsnwesson, generally such PRs are planned to be reviewed by owning squad (aperture in this case). In cases where its someone other than the owning squad we tend to tag them as reviewers. Hope this helps |
@BilalQamar95 thanks for clarifying! I'll be adding a couple of labels to make it clear that this is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran it locally and looks good to me!
Ah, looks like there is a package-lock conflict @BilalQamar95 . once that's resolved, I can merge and deploy the PR! |
Hi @jsnwesson, I have resolved the conflicts |
@BilalQamar95 @jsnwesson this pull request removed the As far as I can see this was an intentional. I'll open another pull request to get the required package back. Please don't remove, otherwise Tutor MFE builds will be broken. Fix: |
Part of openedx/axim-engineering#23
This replaces the
@edx/paragon
and@edx/frontend-build
package.Imports have been updated to use the same locations in the new package.