Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fixed displaying banner and certificates on mobile view #999

Conversation

Lunyachek
Copy link
Contributor

This is backport from Master - #860

  • Fixed displaying banner on mobile view
  • Fixed displaying list of certificates on mobile view

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 2, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (open-release/quince.master@ac277ee). Click here to learn what that means.

Additional details and impacted files
@@                      Coverage Diff                      @@
##             open-release/quince.master     #999   +/-   ##
=============================================================
  Coverage                              ?   66.82%           
=============================================================
  Files                                 ?       52           
  Lines                                 ?      850           
  Branches                              ?      176           
=============================================================
  Hits                                  ?      568           
  Misses                                ?      272           
  Partials                              ?       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Apr 2, 2024
@mphilbrick211 mphilbrick211 requested a review from a team April 2, 2024 17:17
@mphilbrick211
Copy link

Hi @openedx/2u-aperture! This is ready to merge (master has already been merged).

@justinhynes justinhynes merged commit 90ed944 into openedx:open-release/quince.master Apr 15, 2024
9 checks passed
@openedx-webhooks
Copy link

@Lunyachek 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@Lunyachek Lunyachek deleted the lunyachek/feat/certificates-banner-styles-quince branch April 18, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants