chore: add subdirectory slug format for bootcamps #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #910 +/- ##
==========================================
+ Coverage 66.96% 66.97% +0.01%
==========================================
Files 128 128
Lines 3200 3201 +1
Branches 927 927
==========================================
+ Hits 2143 2144 +1
Misses 1008 1008
Partials 49 49
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
AliAdnanSohail
approved these changes
Sep 4, 2023
DawoudSheraz
reviewed
Sep 7, 2023
src/utils/utils.test.js
Outdated
Comment on lines
133
to
152
| it( | ||
| 'returns the old course url slug pattern when courseType is bootcamp and updatedSlugFlag is false', | ||
| () => { | ||
| const updatedSlugFlag = false; | ||
| const courseType = BOOTCAMP_SLUG; | ||
|
|
||
| expect( | ||
| utils.getCourseUrlSlugPattern(updatedSlugFlag, 'external-source', courseType), | ||
| ).toEqual({ | ||
| slug_format: COURSE_URL_SLUG_PATTERN_OLD, | ||
| error_msg: 'Course URL slug contains lowercase letters, numbers, underscores, and dashes only.', | ||
| }); | ||
| }, | ||
| ); | ||
|
|
||
| it( | ||
| 'returns the bootcamp subdirectory slug pattern when courseType is bootcamp and updatedSlugFlag is true', | ||
| () => { | ||
| const updatedSlugFlag = true; | ||
| const courseType = BOOTCAMP_SLUG; | ||
|
|
||
| expect( | ||
| utils.getCourseUrlSlugPattern(updatedSlugFlag, 'external-source', courseType), | ||
| ).toEqual(JSON.parse(COURSE_URL_SLUGS_PATTERN)['external-source'][BOOTCAMP_SLUG]); | ||
| }, | ||
| ); |
There was a problem hiding this comment.
You can use test.each to turn these into ddt style tests.
Or remove updatedSlugFlag & courseType variables and use the values directly in fn call.
DawoudSheraz
approved these changes
Sep 7, 2023
AfaqShuaib09
force-pushed
the
afaq/prod-3592
branch
from
b5ab9eb to
815619b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROD-3592
This PR adds the test in publisher to verify the URL slug format for bootcamps.