Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add variant ID field CourseRun form #931

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

AfaqShuaib09
Copy link
Contributor

@AfaqShuaib09 AfaqShuaib09 commented Nov 22, 2023

PROD-3742

This PR adds variant_id to CourseRunForm and make it visible only for external courses

image

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b9c5cbc) 67.17% compared to head (356d95b) 67.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #931      +/-   ##
==========================================
+ Coverage   67.17%   67.25%   +0.08%     
==========================================
  Files         128      128              
  Lines        3211     3219       +8     
  Branches      927      931       +4     
==========================================
+ Hits         2157     2165       +8     
  Misses       1005     1005              
  Partials       49       49              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AfaqShuaib09 AfaqShuaib09 marked this pull request as draft November 22, 2023 09:14
@AfaqShuaib09 AfaqShuaib09 marked this pull request as ready for review November 22, 2023 20:29
Copy link
Contributor

@DawoudSheraz DawoudSheraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested it locally but looks alright.

@AfaqShuaib09 AfaqShuaib09 merged commit 849c2a5 into master Nov 27, 2023
6 checks passed
@AfaqShuaib09 AfaqShuaib09 deleted the afaq/prod-3742 branch November 27, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants