Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include reviewed to allowed statuses #933

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

kiram15
Copy link
Contributor

@kiram15 kiram15 commented Dec 18, 2023

https://2u-internal.atlassian.net/browse/ENT-8076

Previously, we only allowed you to toggle the enterprise subscription inclusion if your course run was published, but now we are also allowing it if it is reviewed and scheduled. In response to a bug filed by a Harvard customer.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (849c2a5) 67.25% compared to head (7548366) 67.25%.

Files Patch % Lines
src/components/SidePanes/CatalogInclusionPane.jsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #933   +/-   ##
=======================================
  Coverage   67.25%   67.25%           
=======================================
  Files         128      128           
  Lines        3219     3219           
  Branches      931      931           
=======================================
  Hits         2165     2165           
  Misses       1005     1005           
  Partials       49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DawoudSheraz DawoudSheraz removed the request for review from AliAdnanSohail December 26, 2023 05:33
@AfaqShuaib09 AfaqShuaib09 merged commit 4a01a5b into openedx:master Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants