Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: studio dropdown hover styles #433

Merged
merged 5 commits into from
Nov 16, 2023

Conversation

KristinAoki
Copy link
Member

JIRA Ticket: TNL-11205

Nav bar text disappears when focus and hover states are both true. Very interesting find! This will be true for all pages using the header from frontend-component-header. This does not happen when a user is only hovering over a button. This bug only appears when using the edx brand styles. This seems to be happening to all buttons that use the tertiary variant.

Testing

  1. Using the tab key, tab over to any of the nav bar dropdowns.
  2. Hover over the active dropdown with your mouse.
  3. All text should remain visible with no button color change.
  4. Hover over another button that is not focused.
  5. The background of the button should be blue with white text.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (665653e) 66.96% compared to head (6235a92) 66.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #433   +/-   ##
=======================================
  Coverage   66.96%   66.96%           
=======================================
  Files          25       25           
  Lines         339      339           
  Branches       78       78           
=======================================
  Hits          227      227           
  Misses        110      110           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KristinAoki KristinAoki merged commit bace828 into master Nov 16, 2023
6 checks passed
@KristinAoki KristinAoki deleted the KristinAoki/fix-studio-dropdown-hover-styles branch November 16, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants