From 878483176a6cb5c1f6beca3abc25bd02a5c5c6be Mon Sep 17 00:00:00 2001
From: Jason Wesson
Date: Fri, 8 Sep 2023 01:39:00 +0000
Subject: [PATCH] fix: lint issues in example apps
---
example-plugin-app/.eslintrc.js | 3 +--
example-plugin-app/env.config.js | 4 ++--
example/.eslintrc.js | 3 +--
example/env.config.js | 2 +-
example/src/PluginsPage.jsx | 13 ++++++++++---
5 files changed, 15 insertions(+), 10 deletions(-)
diff --git a/example-plugin-app/.eslintrc.js b/example-plugin-app/.eslintrc.js
index f3d99fb99..cdd5b8379 100755
--- a/example-plugin-app/.eslintrc.js
+++ b/example-plugin-app/.eslintrc.js
@@ -4,7 +4,7 @@ const config = getBaseConfig('eslint');
config.rules = {
'import/no-extraneous-dependencies': ['error', {
- 'devDependencies': [
+ devDependencies: [
'**/*.config.js',
'**/*.test.jsx',
'**/*.test.js',
@@ -19,7 +19,6 @@ config.rules = {
}],
'jsx-a11y/anchor-is-valid': ['error', {
components: ['Link'],
- specialLink: [],
specialLink: ['to'],
aspects: ['noHref', 'invalidHref', 'preferButton'],
}],
diff --git a/example-plugin-app/env.config.js b/example-plugin-app/env.config.js
index 8cb0bf4c7..86ca89889 100644
--- a/example-plugin-app/env.config.js
+++ b/example-plugin-app/env.config.js
@@ -1,4 +1,4 @@
-const config = {
+const config = { // eslint-disable no-unused-vars
ACCESS_TOKEN_COOKIE_NAME: 'edx-jwt-cookie-header-payload',
BASE_URL: 'http://localhost:8081',
CREDENTIALS_BASE_URL: 'http://localhost:18150',
@@ -23,4 +23,4 @@ const config = {
FAVICON_URL: 'https://edx-cdn.org/v3/default/favicon.ico',
IGNORED_ERROR_REGEX: null,
PORT: 8081,
-}
+};
diff --git a/example/.eslintrc.js b/example/.eslintrc.js
index f3d99fb99..cdd5b8379 100755
--- a/example/.eslintrc.js
+++ b/example/.eslintrc.js
@@ -4,7 +4,7 @@ const config = getBaseConfig('eslint');
config.rules = {
'import/no-extraneous-dependencies': ['error', {
- 'devDependencies': [
+ devDependencies: [
'**/*.config.js',
'**/*.test.jsx',
'**/*.test.js',
@@ -19,7 +19,6 @@ config.rules = {
}],
'jsx-a11y/anchor-is-valid': ['error', {
components: ['Link'],
- specialLink: [],
specialLink: ['to'],
aspects: ['noHref', 'invalidHref', 'preferButton'],
}],
diff --git a/example/env.config.js b/example/env.config.js
index 63b0628dd..c89183fef 100644
--- a/example/env.config.js
+++ b/example/env.config.js
@@ -1,5 +1,5 @@
// Note that in an actual application this file would be added to .gitignore.
-const config = {
+const config = { // eslint-disable no-unused-vars
JS_FILE_VAR: 'JS_FILE_VAR_VALUE_FOR_EXAMPLE_APP',
EXAMPLE_VAR: 'Example Value',
ACCESS_TOKEN_COOKIE_NAME: 'edx-jwt-cookie-header-payload',
diff --git a/example/src/PluginsPage.jsx b/example/src/PluginsPage.jsx
index 9672ec231..355ca5afd 100644
--- a/example/src/PluginsPage.jsx
+++ b/example/src/PluginsPage.jsx
@@ -19,9 +19,16 @@ export default function PluginsPage() {
a plugin configuration like the one commented out above in PluginsPage.jsx.
-
+
This is default plugin content.