Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert react-redux, react-intl and paragon to release it as breaking change #558

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

abdullahwaheed
Copy link
Contributor

Description:

Reverts #548 and #547 since its breaking consumers and we have to release it as Breaking Change

Merge checklist:

  • Consider running your code modifications in the included example app within frontend-platform. This can be done by running npm start and opening http://localhost:8080.
  • [] Consider testing your code modifications in another local micro-frontend using local aliases configured via the module.config.js file in frontend-build.
  • Verify your commit title/body conforms to the conventional commits format (e.g., fix, feat) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.

Post merge:

  • After the build finishes for the merged commit, verify the new release has been pushed to NPM.

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (dbb3c68) 83.08% compared to head (c83cb97) 83.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #558   +/-   ##
=======================================
  Coverage   83.08%   83.08%           
=======================================
  Files          40       40           
  Lines        1064     1064           
  Branches      194      194           
=======================================
  Hits          884      884           
  Misses        168      168           
  Partials       12       12           

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@abdullahwaheed abdullahwaheed merged commit 6c8e66e into master Sep 11, 2023
@abdullahwaheed abdullahwaheed deleted the abdullahwaheed/revert-breaking-dependencies branch September 11, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants