Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated jest to v29 & frontend-build major version upgrade #661

Merged
merged 9 commits into from
Apr 22, 2024

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Mar 12, 2024

Description:

Updated jest to v29 & frontend-build major version upgrade

BREAKING CHANGE: Due to peerDependency upgrade of frontend-build this goes as a breaking change

Merge checklist:

  • Consider running your code modifications in the included example app within frontend-platform. This can be done by running npm start and opening http://localhost:8080.
  • Consider testing your code modifications in another local micro-frontend using local aliases configured via the module.config.js file in frontend-build.
  • Verify your commit title/body conforms to the conventional commits format (e.g., fix, feat) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.

Post merge:

  • After the build finishes for the merged commit, verify the new release has been pushed to NPM.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.41%. Comparing base (441800f) to head (4a0f519).
Report is 5 commits behind head on alpha.

❗ Current head 4a0f519 differs from pull request most recent head aa2169e. Consider uploading reports for the commit aa2169e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha     #661      +/-   ##
==========================================
- Coverage   83.50%   83.41%   -0.10%     
==========================================
  Files          40       40              
  Lines        1073     1073              
  Branches      197      197              
==========================================
- Hits          896      895       -1     
- Misses        165      166       +1     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arbrandes
Copy link
Contributor

Can you modify this to use the latest frontend-build alpha, and then rebase the PR on this repo's alpha branch?

@arbrandes arbrandes self-requested a review March 20, 2024 16:59
@BilalQamar95 BilalQamar95 changed the base branch from master to alpha March 21, 2024 09:03
@BilalQamar95
Copy link
Contributor Author

BilalQamar95 commented Mar 21, 2024

Can you modify this to use the latest frontend-build alpha, and then rebase the PR on this repo's alpha branch?

@arbrandes I have updated it to use frontend-build alpha & rebased the PR to alpha branch of this repo

@jristau1984
Copy link
Contributor

@arbrandes can you please respond to the question above? We would like to move this forward if there are no more concerns. Thanks!

@BilalQamar95 BilalQamar95 changed the title Updated frontend-build to bump jest version to v29 feat: updated jest to v29 & frontend-build major version upgrade Apr 22, 2024
@BilalQamar95 BilalQamar95 marked this pull request as ready for review April 22, 2024 08:21
…into bilalqamar95/frontend-build-jest-upgrade
@BilalQamar95 BilalQamar95 changed the base branch from alpha to master April 22, 2024 12:58
@BilalQamar95 BilalQamar95 merged commit f066ecb into master Apr 22, 2024
5 checks passed
@BilalQamar95 BilalQamar95 deleted the bilalqamar95/frontend-build-jest-upgrade branch April 22, 2024 13:08
bra-i-am pushed a commit to eduNEXT/frontend-platform that referenced this pull request Aug 22, 2024
…nedx#661)

BREAKING CHANGE: Due to peerDependency upgrade of frontend-build this goes as a breaking change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants