Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tagging] UX Refinements from Sandbox Round 2 #167

Closed
bradenmacdonald opened this issue Dec 19, 2023 · 5 comments
Closed

[Tagging] UX Refinements from Sandbox Round 2 #167

bradenmacdonald opened this issue Dec 19, 2023 · 5 comments

Comments

@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Dec 19, 2023

  1. Refresh the count of tags on the unit/outline page(s) after the user makes edits in the tag drawer
  2. "The tag drawer doesn't seem to be fully responsive. When shrinking, the tags cut off instead of shrinking as well. If the cut-off is inevitable, we should explore other solutions to viewing the full tag names (hovers? etc)"
    • Hold off on this one as a new UX design is being worked on.
  3. the layer over the course outline is too dark when the tag drawer is open.
  4. Slack: On this page, clicking "Manage Tags" for a component (not the unit) that has no tags, then clicking Add Tags at the top makes the list of tags appear offscreen. (Check if this issue is gone or not)
@ChrisChV
Copy link

More items from #157 to be updates on the description:

  • Slack: On this page, clicking "Manage Tags" for a component (not the unit) that has no tags, then clicking Add Tags at the top makes the list of tags appear offscreen. (Check if this issue is gone or not)
  • Slack: Refresh the count of tags on the unit/outline page(s) after the user makes edits in the tag drawer

@ChrisChV
Copy link

the layer over the course outline is too dark when the tag drawer is open.

@ali-hugo about this, I updated to the color used on figma: #707070

Captura desde 2024-01-12 10-43-01

@ali-hugo
Copy link

@ChrisChV Thanks for letting me know. It looks fine from the screenshot, but will be easier to evaluate once it has been pushed to the sandbox. I'll take a look after the next update. 👀

@ChrisChV
Copy link

Slack: On this page, clicking "Manage Tags" for a component (not the unit) that has no tags, then clicking Add Tags at the top makes the list of tags appear offscreen. (Check if this issue is gone or not)

FTR, this issue is gone in the current master branch of edx-platform and course MFE.

@bradenmacdonald
Copy link
Contributor Author

@ChrisChV That's great. Please make sure to test with a smaller screen too though; sometimes I found that the reported issues only occur if the browser window is small, like on a small laptop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants