fix: transifex pull is failing #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
shadinaif
force-pushed
the
shadinaif/fix-pull-failing
branch
from
c3ed77f to
ca1f3e0
Compare
|
Please review @OmarIthawi |
OmarIthawi
reviewed
Sep 30, 2023
There was a problem hiding this comment.
Thanks @shadinaif!!
One naming suggestion and this should be good to go.
Fix by merging `transifex.txt` into `translations.txt` and using only the latter to avoid missing requirements scenarios Refs: FC-0012 OEP-58
shadinaif
force-pushed
the
shadinaif/fix-pull-failing
branch
from
ca1f3e0 to
ef7546c
Compare
OmarIthawi
approved these changes
Sep 30, 2023
|
@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
shadinaif
added a commit
to zeit-labs/openedx-translations
that referenced
this pull request
Sep 30, 2023
Refs: FC-0012 OEP-58
OmarIthawi
added a commit
that referenced
this pull request
Oct 1, 2023
fix: transifex pull is failing - patch for #1373
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix by merging
transifex.txtintotranslations.txtand using only the latter to avoid missing requirements scenariosThis contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
Update: still failing, fixed here #1374