Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enabled translations for frontend-enterprise repo. #6076

Merged
merged 2 commits into from
May 28, 2024

Conversation

saleem-latif
Copy link
Contributor

This PR adds frontend-enterprise to extraction and transifex Github actions to enable translations for the repo.

@OmarIthawi
Copy link
Member

OmarIthawi commented May 26, 2024

Thanks @saleem-latif.

Please test on your fork and let us know if the configurations are working.

Semi-outdated instructions are here: https://docs.openedx.org/en/latest/developers/how-tos/enable-translations-new-repo.html it should give you a good idea where to start.

@saleem-latif
Copy link
Contributor Author

@OmarIthawi I did not add make pull_translations because we won't be pulling translations here as this repo only contains NPM packages. Let me know if openedx-translation flow require that command.

I have done some testing on my fork, here is the action that ran https://github.com/saleem-latif/openedx-translations/actions/runs/9250930503
It did not run merge-translations step but everything worked correctly. Let me know if there is anything else that needs to be tested as well?

Copy link
Member

@OmarIthawi OmarIthawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @saleem-latif!

@OmarIthawi OmarIthawi merged commit 651a6fa into openedx:main May 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants