From 8294dfc3611dc21ec8c160ccf0254c0256f05fac Mon Sep 17 00:00:00 2001 From: Omar Al-Ithawi Date: Thu, 19 Oct 2023 19:20:58 +0300 Subject: [PATCH] feat: require the validation comment on non-fork PRs --- .github/workflows/validate-translation-files.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/validate-translation-files.yml b/.github/workflows/validate-translation-files.yml index 1a2d996f1f4..79eaa78ab42 100644 --- a/.github/workflows/validate-translation-files.yml +++ b/.github/workflows/validate-translation-files.yml @@ -35,11 +35,10 @@ jobs: exit $has_validation_errors - # Due to GitHub Actions security reasons this will not work on fork pull requests. - # This shouldn't be an issue, because bots writes directly to this repository. - name: Post translation validation results as a comment - if: always() - continue-on-error: true # Don't fail the build if posting the comment fails on fork pull requests. + # Due to GitHub Actions security reasons posting a comment isn't possible on fork pull requests. + # This shouldn't be an issue, because bots writes directly to this repository. + if: ${{ always() && !github.event.pull_request.head.repo.fork }} uses: mshick/add-pr-comment@7c0890544fb33b0bdd2e59467fbacb62e028a096 with: message: |