Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discovery] Implement Toasts container #1858

Open
adamstankiewicz opened this issue Dec 20, 2022 · 1 comment
Open

[discovery] Implement Toasts container #1858

adamstankiewicz opened this issue Dec 20, 2022 · 1 comment
Labels
engineering Engineering

Comments

@adamstankiewicz
Copy link
Member

adamstankiewicz commented Dec 20, 2022

Context

Currently, consumers of Paragon's Toast must render the Toast before its visible (for fade in transition to work properly). However, consumers need to implement their own state to determine whether the Toast is visible or not.

It may be helpful to provide a ToastContainer component with helpful utility function(s) to dynamically create/show Toast notifications as needed throughout the component rendering lifecycle.

Possibly use for inspiration:


Prior notes:

Toast component makes it trivial to render a single toast for a given use case. However, it does not adequately provide a mechanism to support multiple toasts displayed at once, keeping their animation (fade in/out) and their default close behavior.

Ideas

  • Should we separate out the logic of
    • "data" -> toastText
    • Some key that exists used as "global state" to flag when a toast is trigger on/off.
@viktorrusakov viktorrusakov moved this to 📋 Backlog in Paragon Working Group Jan 10, 2023
@adamstankiewicz adamstankiewicz added the engineering Engineering label Jan 24, 2023
@adamstankiewicz adamstankiewicz moved this from Backlog to To Do in Paragon Working Group Nov 20, 2023
@monteri monteri moved this from To Do to In review in Paragon Working Group Dec 7, 2023
@monteri monteri moved this from In review to In progress in Paragon Working Group Dec 7, 2023
@monteri monteri self-assigned this Dec 7, 2023
@bradenmacdonald
Copy link
Contributor

I put a related comment on a PR: open-craft/frontend-app-authoring#38 (comment)

That what we really want when showing a toast is just to "push a message onto the toast queue" so that it will eventually get displayed to the user, without needing to worry about whether or not other toasts are also being displayed now.

@adamstankiewicz adamstankiewicz moved this from In progress to To Do in Paragon Working Group Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Engineering
Projects
Status: To Do
Development

No branches or pull requests

3 participants