-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Product Pull Request] Make course description editable in certs #227
Comments
Thanks for your submission, @openedx/open-edx-project-managers will review shortly. |
Product Info from the PR (29850)DescriptionThis PR makes the default description text that appears under the course title editable/configurable for certificates. Supporting informationJIRA tickets: BB-5819 ScreenshotsCreating new certificates: Testing instructions
|
Product Review should be assigned to Claire Zhang. |
@czhang0912 do you have any questions about this idea? Any concerns about its effect on the user experience or if it conflicts with anything that you have planned? |
Hi @czhang0912! Just flagging Kelly's comment / feedback for product here in the original ticket. |
Hi @czhang0912 - friendly ping on this! |
@mphilbrick211 @ProductRyan As Kelly mentioned, we are current in the progress building the roadmap to extract the credentials from the LMS. We would like to focus on prioritizing the existing fields and not introducing another layer of complexities. Please let me know the use cases of this feature and if is critically needed for the future support in the long run. |
@pkulkark and @gabor-boros you both were involved in the PR. Could someone from the OpenCraft team provide a brief statement about the customer need that this work fulfills? What it does is pretty obvious, but we'd like to know
|
@e0d Sure I can answer here. This came as a requirement for one of our clients. They are no longer with us but at the time of submitting the PR it was a blocker for them. They had multiple courses and had certificates configured for each of them. While all other fields in the certificate was configurable, the course description was hard-coded. We added this to our fork of edx-platform which we use for our clients. |
Hi all - linking Kelly's most recent comment from the original PR here in case people didn't see. |
@pkulkark I'm copying over the feedback from one of the eng reviewers on the 2U side: _"This is still very far from viable from my perspective. I would still like to see a clear set of requirements from Product and a sense of the level of need, but from there we would also need to work through several other questions about the particulars of how this feature should work, such as: What does the field need to support? HTML? Django templating commands? Does it have a character limit? I don't think these are insurmountable questions, but given that this request came from a single client who is no longer with you, do you have access to the market input you'd need to define to this level of detail? Likewise, that change your relative prioritization of this enhancement? |
@jmakowski1123 No I do not have access to the market input needed. As I mentioned it was a request from just that one client. That being said, we did add this to our fork which is used by other clients so I'm not sure if others might be using it. My only additional comment is that the changes made here were made exactly like what's existing for Course Title. The same questions would be applicable to Course Title as well. Also this was meant to be a temporary solution until the course certificates were moved to credentials. So if there are reservations about it, I'm fine with closing the PR and reverting the changes on our fork. In case any of the other clients request it, we can reopen it. |
Friendly ping on this @jmakowski1123! |
Given that this was initially implemented as a temporary solution until the Credentials work began, and it was initially built for the sake of one client among many, it's not a high priority enhancement to pursue now. @pkulkark If you find this creates a problem for multiple clients who may be using it without our knowledge, let me know and we can reconsider. Otherwise, closing this without pursuing for now. |
Closing as this is marked "Abandoned" on the PR board. It may always be re-opened if needed. |
For Contributing Author:
This is the Primary Product Ticket for the following community contribution: Make course description editable in certificates
Checklist prior to undergoing Product Review:
The following information is required in order for Product Managers to be able to review your pull request:
Only if necessary:
Related PRs
For Product Manager doing the review:
What criteria should be analyzed from Product to approve a PR?
The text was updated successfully, but these errors were encountered: