[Product Pull Request] feat: Auth form visual enhancements

[jmakowski1123]

For Contributing Author:

This is the Primary Product Ticket for the following community contribution: Cosmetic changes to the registration page to remove a preloader that pops up when switching between Login and Registration when the third-party login is disabled.

Checklist prior to undergoing Product Review:

The following information is required in order for Product Managers to be able to review your pull request:

• Explanation of the problem being solved
• Description of how users will be impacted, and which users will be impacted
• Screenshots or video showing the functionality or fix, before and after
• Reproduction steps and/or testing steps

Only if necessary:

• If necessary, links to corresponding configuration changes
• If necessary, links to corresponding enablement changes, particularly waffle/toggle status details

Related PRs

• feat: Auth form visual enhancements (master) frontend-app-authn#767
• feat: Auth form visual enhancements (olive) frontend-app-authn#766

For Product Manager doing the review:

What criteria should be analyzed from Product to approve a PR?

• The problem being solved by the feature or fix is clear.
• There is clarity on how the change or fix will impact the end user.
• It is clear that the change will not negatively impact users or other areas of the platform.
• The change is implemented comprehensively.
• Any changes to UI use the current, standard Paragon Design System: https://paragon-openedx.netlify.app/

[github-actions]

Thanks for your submission, @openedx/open-edx-project-managers will review shortly.

[jmakowski1123]

This is a copy of PR to master branch

Description

Cosmetic improvements for the login/registration page. Changes in React are related to the situation when third-party login providers is disabled, but when switching between Login and Registration tabs, we still see a preloader that is not necessary in this situation.

2023-03-01.16.08.24.mov

And sass changes are related to the suggested username field, which is too short and can be extended to match the neighboring inputs.

After making our changes, we no longer see preloaders in cases where third-party login providers are turned off.

2023-03-01.16.47.42.mov

And suggested username field looks pretty

[mphilbrick211]

Hi @ProductRyan - just checking in on these two PRs - are you still reviewing?

openedx/frontend-app-authn#767
openedx/frontend-app-authn#766

[ProductRyan]

I'd like to pull in the PM who is working on the login page here at 2U, I've contacted them internally and made them aware of this ticket.

[mphilbrick211]

Hi @ProductRyan - any update on this?

Note that Engineering is also in the midst of reviewing.

[ProductRyan]

The 2U PM for this area of the platform is Poornima Hanumara - who is out this week. I have pinged them to take a look when they get back.

[phanumara]

The changes look good from a product standpoint. We need to ensure that it doesn't break any existing scenarios. Engineering(Zainab Amir) is looped in to ensure proper implementation. Thanks!

[mphilbrick211]

The changes look good from a product standpoint. We need to ensure that it doesn't break any existing scenarios. Engineering(Zainab Amir) is looped in to ensure proper implementation. Thanks!

Hi @phanumara! Just to confirm, your product review is complete? If so, we'll move the original ticket to Engineering for review.

[phanumara]

@mphilbrick211 yes, thank you!

[itsjeyd]

@jmakowski1123 @mphilbrick211 It looks like this is done; the PRs for it have been merged. Can we close this ticket and move it to Shipped on the roadmap?