Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course and Library import should accept .zip files in addition to .tar.gz #285

Closed
ormsbee opened this issue Sep 21, 2023 · 2 comments
Closed
Assignees

Comments

@ormsbee
Copy link

ormsbee commented Sep 21, 2023

Background

The Import pages for Course and v1 Libraries (the current default Library experience) only accept .tar.gz files. Zip files are more commonly used on MacOS and Windows, and the Python standard library has support for this type. We should accept Zip files as well.

Image

Motivation

  • Zip files are more commonly used on MacOS and Windows, and can be created via right-clicking after changes are made, rather than using the command-line.
  • It makes things easier for courses authored in a GitHub repository, since an entire GitHub repo can be downloaded as a zip file.

Acceptance criteria:

  • The UI should indicate that the user can upload either .tar.gz or .zip files.
  • The backend import code should be updated to properly accept and decompress .zip files.
  • Exports should continue to generate .tar.gz files as they do today (i.e. don't break backwards compatibility).

Testing notes

A common workflow will be for someone to download the existing course to their local machine, decompress it, edit a number of files, re-compress the folder, and then upload. Because of this:

  • The code should handle whatever Zip file is generated when you right-click-and-compress something from the OS UI. (I don't know if it generates a sub-folder or not.)
  • We should be able to gracefully handle cases where there are spaces in the folder name, since they're often going to be named things like "course 7", "course 8", as they keep downloading over time.
@ormsbee ormsbee self-assigned this Sep 21, 2023
@ormsbee ormsbee converted this from a draft issue Sep 21, 2023
@github-actions
Copy link

Thanks for your submission, @openedx/open-edx-project-managers will review shortly.

@Agrendalath
Copy link
Member

Resolved by openedx/edx-platform#34191.

@github-project-automation github-project-automation bot moved this from Ideation to Shipped in Nutmeg in Open edX Roadmap Mar 8, 2024
@jmakowski1123 jmakowski1123 moved this from Shipped in Nutmeg to Shipped in Open edX Roadmap Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Shipped
Development

No branches or pull requests

2 participants