-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pull Request] A feature flag to disable date tab. #392
Comments
Thanks for your submission, @openedx/openedx-product-managers will review shortly. |
Site Level Feature Flag: Not Recommended for Merge This is not a strong stance to be clear, but I don't know if we expect this will be commonly used at the site level. Course Level Pages & Resources Card + Disable Option: Recommended for Merge (?!?) Is it strange that the case for making this a site-level feature flag seems weak, but that the experience completeness + customization balance of having Dates be added for each course to decide whether they want to turn it off (which would be VERY infrequently used, as with turning off the progress page) is somehow a more compelling case in my mind? It feels a bit strange to me, but somehow I think if I'd seen this as a proposal to "Match Dates page customization for Courses" and enable similar functionality as Progress / Discussion / Wiki / Textbooks / Static Pages, it would have been a thumbs up from me. Thanks for the proposal @farhaanbukhsh - Hopefully others chime in and share their thoughts as well. |
Actually @marcotuts you are right on this part because intuitively even I thought that it makes more sense for the course to have a setting where we can turn the date tab on and off and it was very human to think that. But hear me out on this the argument is if I want to disable a date tab on an instance I would want that behavior for all the courses in a uniform fashion whereas having a date tab for some courses while not having one on another will create a dissonance in the learners. Now, this might not be true for wiki, discussion or pages since they have functionality and actions attached to them while date is just a way of conveying information. I am open to suggestions and better way of taking this approach here. Thanks a lot for the quick revert @marcotuts |
Hi @farhaanbukhsh, the inconsistency you highlight when you enable/disable course tabs within an instance is absolutely an issue, but at edX we found organizations that needed / (or felt they needed) this level of control even if it left learners with not a consistent cross-course experience. This is somewhat related to the example I mentioned in the Progress controls PR (quote excerpts is below)- #389
Instance Level - It should be possible to more easily control which tabs are shown / hidden by default in my course, and which areas of the Pages & Resources view should be hidden. This won't be common but it allows for the control of hiding all Dates / Progress / Discussion tabs or any combination of these at the instance level. This is most like the PR proposal currently, though I wonder if we should consider what it would look like to configure any of the course tabs / pages & resources areas consistently instead of just 1 feature flag for dates. Do any of the other tabs have feature flags or configuration options today? Course Level - How common should the need be to be able to disable a page at the course level? The Pages & Resources view / UX experience doesn't place a value judgment on whether you should do this but it does show the controls for Discussion, Wiki, Progress, but it is missing Dates currently. FWIW I'm not sure that I agree that the current pages have functionality/actions attached to them and Dates does not. Dates let you see / action on verification/upgrade / assignment deadlines the same way that the progress page MOSTLY conveys information and also has actions like clicking through to assignments, upgrading, etc. (Discussions + Wiki are for sure very different and have lots of interactivity) This isn't necessarily in scope for this PR but still worth considering at some future point in time. |
Hey @marcotuts sorry for the late reply.
Most of them do for example the discussion tab doesn't show up unless and until we have enabled the plugin, the same is true for Page and Resources. The tab bar that we have is quite dynamic with what it can have hence I think it will be a good contribution to do the same with Date. By default the Date tab is visible and if we want we can toggle it to false on an instance level. |
1. Is there an existing issue for this?
2. What new feature or functionality would you like to request?
There is no way to disable tabs on the course page
We need a way to disable individual Tabs. We started this with 'Dates Tab', this feature flag helps to hide 'Dates Tab' throughout the instance. For this, we have worked on a PR:
openedx/edx-platform#34511
3. What product area does this feature affect?
Courseware
4. Please describe the scope of the feature
This affects the tabs that appear on the courseware LMS page.
5. Please describe why you see a need for this feature
This feature flag helps to customize the instance and helps to convey the information more realistically.
6. Please describe the potential impact and/or value of this feature
As mentioned above it helps in customizing the instance.
7. Please provide 2-3 use cases and/or user stories in support of this feature
Helps to hide the dates since there are times when it is not relevant to the organization using it.
8. Any additional information you'd like to provide?
No response
The text was updated successfully, but these errors were encountered: