Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax warning over comparison of literals using is. #27

Closed
wants to merge 1 commit into from

Conversation

tirkarthi
Copy link

Description: Fixes syntax warnings. Closes #26

Reviewers:

  • tag reviewer
  • tag reviewer

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.

@openedx-webhooks
Copy link

Thanks for the pull request, @tirkarthi! I've created OSPR-4406 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Apr 21, 2020
@natabene
Copy link

@tirkarthi Thank you for the contribution! When you have a chance, could you please send in a signed Contributor Agreement mentioned in the earlier comment? You only need to do this once and we can then review all your future code contributions. Thanks

@tirkarthi
Copy link
Author

Sorry, I might not be able to go ahead due to CLA. Since the fix is simple enough I will leave it to someone who can move it forward with the patch.

@tirkarthi tirkarthi closed this Apr 22, 2020
@openedx-webhooks
Copy link

@tirkarthi Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@natabene
Copy link

@tirkarthi Sorry to hear, is there any way I can help you with the CLA? Are you missing necessary equipment or do the rights for this change not belong to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U rejected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax warning due to comparison of literals using is
3 participants