Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Superset permissions cached indefinitely #406

Closed
bmtcril opened this issue Sep 21, 2023 · 1 comment · Fixed by #443 or #489
Closed

Bug: Superset permissions cached indefinitely #406

bmtcril opened this issue Sep 21, 2023 · 1 comment · Fixed by #443 or #489
Assignees

Comments

@bmtcril
Copy link
Contributor

bmtcril commented Sep 21, 2023

The security manager uses an LRU cache on LMS calls to get a user's courses, on a small site it may never expire leading to old permisisons such as not being able to log in to Superset or having instructor access when it has been revoked: https://github.com/openedx/tutor-contrib-aspects/blob/90a8afd161b4664352a3553b919a73a5ad8a4b98/tutoraspects/templates/aspects/apps/superset/pythonpath/openedx_sso_security_manager.py#L193C1-L194

We should either make this a time based cache or remove it altogether.

@bmtcril
Copy link
Contributor Author

bmtcril commented Oct 18, 2023

We're seeing reports of this on the beta server again, even though I've confirmed it's got the fix for the LRU cache, so I'm going to reopen it. Waiting to hear if bouncing the server fixes it like it did last time. So far it's persisted over an hour without getting new permissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant