-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Olive Testing] Android plugin #211
Comments
I can confirm that logging in is impossible. I'm getting the following logs from the server:
LMS is replying to POST /oauth2/access_token/ with a 401 Unauthorized error. I have no idea why. If someone with mobile dev skills reads this, I could use a hand... |
@regisb Custom Android build using oauth client credentials from https://olive.demo.overhang.io/oauth2/access_token/ works fine (at least Login step). So I suspect incorrect oauth client_id/token being added during the apk build step. Need to review the build process. |
Additional testing for Android appProfile editingSteps:
Status: PASS Enrolled course on main screenSteps:
Status: PASS Open enrolled course from the main screenSteps:
Status: FAILED |
@cmltaWt0 thanks for the detailed input!.. I was going over the logs of edx-app-android to see if there might be already a fix for the last failed test and I found this openedx-unsupported/edx-app-android/pull/1694 which I think is realted to the last test, if yes then we should add it to #205 |
Awesome jobs! So @cmltaWt0 I presume we should add all these as new test cases. These will be the first new test cases added to the sheet since testing began. I endeavour to add them tomorrow. |
Android app was upgraded to 3.2.2 on the Olive demo server. Can you please run the failed tests again? |
@cmltaWt0, have you been able to re-run the tests? |
Sure, will do today. |
Tested the 3.2.2 version on emulator and on real device. It's crashed on login/register step.
@regisb could you check the configuration option for the build please? |
If configuration looks good I can try to backport the |
Thanks for testing @cmltaWt0. I have no idea what is going on. Configuration is supposed to be ok, as I didn't change it since the last release. I also observe that the app is crashing, though I don't know why. (I don't even know how to generate a crash report on my phone...) No logs are generated on the server. You are talking about this PR, right? openedx-unsupported/edx-app-android#1694 It should already be present in the app, as we are running 3.2.2 which was published in October: https://github.com/openedx/edx-app-android/releases/tag/release%2F3.2.2 Any other idea? EDIT: I downgraded the generated app from 3.2.2 to 3.1.4. With 3.1.4 I am able to login... but then the app crashes on opening the demo course. I need to figure out what happened between those two versions that could cause the crash in v3.2.2. EDIT: Version 11bb840580df92098717e875c7d68b6a994a9205 (latest commit from the master branch) is also broken. App also crashes after login. EDIT: for the record, 3.0.2 was the last known version to work (in Nutmeg). I tried it with Olive and it works. So if we can't get 3.2.2 to work we'll have to keep 3.0.2. |
Release janitor check: what are we doing here, if anything, for Olive.1? We only have a couple of hours. |
I downgraded the android plugin to 3.0.2. We'll work later to upgrade to 3.2.2. |
Following our today BTR call, there was a bug that I encournted in different context enrollment is not possible when using the APK. It would return 400 code, the way to resolve for that was to disable the ProGuard featuer. By commenting the following lines: In particualr I think this commit openedx-unsupported/edx-app-android@7090944 is probably the reason for bug. |
I'm a terrible mobile developer and I need help with this issue, so I'll unassign myself. As an acceptance criteria, I'd like someone to open a PR on the tutor-android plugin repo to upgrade the app from 3.0.2 to 3.2.2 (or later). Users should be able to login, register and enroll in courses from the app. |
@cmltaWt0, are you currently working on this? otherwise, let's mark this issue as unassigned to let people know this issue is requiring someone to work on it. |
@jalondonot actually I don't. Was just a reported and tried to help to diagnose the issue. |
I mean, the android app is really supposed to be working in Quince, so my guess is that yes, this issue is now resolved. |
Testings env
Login
State: Failed
STR:
Registration
State: Failed
Note - user is actually created. Register the same user will give and Existent user error.
STR:
Register page
TOS link makrup is broken.
The text was updated successfully, but these errors were encountered: