This repository has been archived by the owner on Feb 4, 2020. It is now read-only.
Refactor to use request library instead of got #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Now uses the request library (and request-promise) instead of got - Accepts additional request options (such as auth) on construction -`inspect` now uses the /system/function/name endpoint instead of filtering /system/functions - Added jsdoc comments Signed-off-by: Alex King <[email protected]>
|
Have another branch that adds support for calling async functions as well, can merge that into here if we'd like, otherwise I'll submit it as a new PR after this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #7 by allowing us to send in additional options for the http requests to use.
requestlibrary (andrequest-promise) fromgot(not sure if this is better, but it's simpler for now and more widely used)request.defaults()feature)inspect()now uses the new/system/function/nameendpoint instead of filtering/system/functionsThis should be fully backwards compatible with the previous version (at least according to the tests) so I've only bumped to 0.1.2 from 0.1.1, but we may want to make it 0.2.0, not sure.
Signed-off-by: Alex King