From 835be0f4f530b80b12ace3dfdcc5922bf6611470 Mon Sep 17 00:00:00 2001 From: "Han Verstraete (OpenFaaS Ltd)" Date: Tue, 6 Sep 2022 11:11:23 +0200 Subject: [PATCH] Fix nil-pointer when no scaling config for function Signed-off-by: Han Verstraete (OpenFaaS Ltd) --- main.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/main.go b/main.go index b4af01e..f718156 100644 --- a/main.go +++ b/main.go @@ -475,12 +475,13 @@ Features detected: scalingDown := 0 for _, fn := range functions { + scalingConfigured := fn.Scaling != nil - if fn.Scaling.GetZero() == "true" { + if scalingConfigured && fn.Scaling.GetZero() == "true" { scalingDown++ } - if fn.Scaling.GetZeroDuration() != "" { + if scalingConfigured && fn.Scaling.GetZeroDuration() != "" { dur, err := time.ParseDuration(fn.Scaling.GetZeroDuration()) if err == nil && dur < time.Minute*5 { fmt.Printf("⚠️ %s scales down after %.2f minutes, this may be too soon, 5 minutes or higher is recommended\n", fn.Name, dur.Minutes())