You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 10, 2023. It is now read-only.
There are error messages in the github integration functions that are generic, where we actually know why the event failed. We could easily update these to give an operator a very quick indication of what's not configured correctly.
I had to go looking into the code while debugging an installation, the code clearly indicated why it failed, but the error was just "error: <name of event, status we tried to give github>" when the actual issue was "github app id not set" or "github private key not accepted" for example.
there are also cases of github-status calling things like git-tar, git-tar failes and github-status just reports "error 500", we could propogate that error much better so we don't have to dig around the services so much.
Expected Behaviour
more descriptive error messages for cases where things failed and we know why, propogate error properly up to parent services.
Current Behaviour
generic error messages and bad propagation of errors in http calls
Possible Solution
Run through the integration starting at the github-status function and look into all the child functions and add more descriptive messages, giving an operator more ov an idea what/where and why things failed
Context
Have to dive into the code when we have set things like github app id, or github private key incorrectly. It should be better presented to admins what they can do to fix stuff.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
There are error messages in the github integration functions that are generic, where we actually know why the event failed. We could easily update these to give an operator a very quick indication of what's not configured correctly.
I had to go looking into the code while debugging an installation, the code clearly indicated why it failed, but the error was just "error: <name of event, status we tried to give github>" when the actual issue was "github app id not set" or "github private key not accepted" for example.
there are also cases of github-status calling things like git-tar, git-tar failes and github-status just reports "error 500", we could propogate that error much better so we don't have to dig around the services so much.
Expected Behaviour
more descriptive error messages for cases where things failed and we know why, propogate error properly up to parent services.
Current Behaviour
generic error messages and bad propagation of errors in http calls
Possible Solution
Run through the integration starting at the github-status function and look into all the child functions and add more descriptive messages, giving an operator more ov an idea what/where and why things failed
Context
Have to dive into the code when we have set things like github app id, or github private key incorrectly. It should be better presented to admins what they can do to fix stuff.
The text was updated successfully, but these errors were encountered: