This repository has been archived by the owner on Nov 28, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 26
A pull request to give the option of merging a few of the changes I've applied #8
Open
johnman
wants to merge
25
commits into
openfin:master
Choose a base branch
from
johnman:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just trying to demonstrate one way of inserting a new view into a specific location. This example checks for a column at two levels and inserts it into the first slot it finds. A real application would use a different approach to locate where it should go.
newChart is easier to read. Removed some properties that were not mandatory and fixed a bug where componentState.name was not unique.
Hide domain from showing in view while waiting for content to load
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
View Host Api and Context Views
Second Example that acts as an application (saving state on close of the main window).
Save and Restore on child windows.
Main View (second example) can not be closed because of view removal