Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParameterNode.get_descendants doesn't include ParameterScale rates and thresholds #1112

Open
nikhilwoodruff opened this issue Mar 22, 2022 · 2 comments · May be fixed by #1113
Open

ParameterNode.get_descendants doesn't include ParameterScale rates and thresholds #1112

nikhilwoodruff opened this issue Mar 22, 2022 · 2 comments · May be fixed by #1113

Comments

@nikhilwoodruff
Copy link
Contributor

nikhilwoodruff commented Mar 22, 2022

Hi there!

I really enjoy OpenFisca, but I recently encountered an issue.

Here is what I did:

Called ParameterNode.get_descendants in a tree with a parameter scale.

Here is what I expected to happen:

Expected an iterator including rates and thresholds from ParameterScale parameters.

Here is what actually happened:

The iterator didn't include the scale parameters.

Here is data (or links to it) that can help you reproduce this issue:

I've written a MWE here on Google Colab.

Context

I identify more as a:

  • Developer (I create tools that use the existing OpenFisca code).

Thanks! Happy to tackle this with a PR if desired. (cc @benjello @sandcha)

@benjello
Copy link
Member

PR welcome @nikhilwoodruff !

@nikhilwoodruff
Copy link
Contributor Author

Thanks @benjello! In progress in #1113

@MattiSG MattiSG linked a pull request May 5, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants