Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade frontend tooling #396

Merged
merged 10 commits into from
Feb 13, 2024
Merged

Conversation

eric-nguyen-cs
Copy link
Contributor

What

  • Change Javascript files into Typescript files (the errors that are not straightforward to fix are ignored for now)
  • Added CRACO to be able to configure Webpack and Eslint
  • Added aliases to remove deeply-nested relative paths (Typescript and Webpack config)
  • Added more relevant Eslint config and fixed errors

alexgarel
alexgarel previously approved these changes Feb 12, 2024
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive ! But I will let @perierc review ;-)

@nobeeakon by any chance are you also interested ?

@alexgarel alexgarel dismissed their stale review February 12, 2024 14:54

I let Charles review !

Copy link
Contributor

@perierc perierc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, thanks, it will improve the developer experience a lot!
I would be really happy if you could make everything work without any @ts-expect-error though 😇 (but it's ok if you're not motivated for that 😁)

taxonomy-editor-frontend/craco.config.js Show resolved Hide resolved
taxonomy-editor-frontend/package.json Show resolved Hide resolved
@eric-nguyen-cs
Copy link
Contributor Author

Good work, thanks, it will improve the developer experience a lot! I would be really happy if you could make everything work without any @ts-expect-error though 😇 (but it's ok if you're not motivated for that 😁)

I've fixed a few other TS errors but I feel that the most important is to add Typescript as to not make any further type error: we can fix the remaining errors when we change the related code
Moreover, I believe that most of the remaining errors come from the fact that the data from the backend API is untyped, which we will be able to fix later!

@eric-nguyen-cs eric-nguyen-cs merged commit 5119baa into main Feb 13, 2024
7 checks passed
@eric-nguyen-cs eric-nguyen-cs deleted the ericn/upgrade-frontend-tooling branch February 13, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants