[Products page] Empty option on unit scale dropdown

[filipefurtad0]

Description

Follow-up from #12787: it introduced the possibility to select an empty value from unit scale dropdown, on the products page. This seems to be a UI issue only, as it not possible to save these changes - attempting to do so, triggers an error.

Expected Behavior

It should not be possible to select an empty value from the unit scale dropdown, on the products page.

Actual Behaviour

It is possible to select an empty value from the unit scale dropdown, on the products page.

Steps to Reproduce

1. Log in as a hub or shop.
2. Create at least one product.
3. Visit the /products page
4. Notice it is possible to select an empty option on the unit scale dropdown.
5. Try to save changes: an error should be displayed and saving should not succeed.

Animated Gif/Screenshot

Workaround

Don't select the empty option.

Severity

bug-s3: a feature is broken but there is a workaround

Your Environment

• Version used: v4.6.8
• Browser name and version: All
• Operating System and version (desktop or mobile): All

Possible Fix

[chahmedejaz]

@filipefurtad0 - I think rather than removing the empty option, we should replace it with the prompt to select the unit scale. How does it sound?
Removing the empty option might result in the unintentional selection of the unit scale by the user.

CC: @RachL

[RachL]

aligned :) 💪

[filipefurtad0]

Hey @chahmedejaz ,

Sorry for the delay in my reply.

We've had a quick chat about this today in testers circle and came to the conclusion, that it is relevant to consider two cases:

• existing variants -> in this case, there should be no empty option, as the variant should already have this previously selected. We're convinced this is a regression introduced by product refactor
• new variants -> when creating a variant, indeed it is relevant to display a prompt to select the unit scale (as you mention, this could lead to unintentional unit scale attribution)

Hope this helps 👍

[chahmedejaz]

• existing variants -> in this case, there should be no empty option, as the variant should already have this previously selected. We're convinced this is a regression introduced by product refactor

Thanks @filipefurtad0 for the feedback.
If the existing variant had an empty option selected previously, then in its place, the prompt will be displayed after the PR. I think that would work?

On the side note, I noticed as of now, we cannot create/update the variant with empty option. I'm not sure if it was the case before or not.

[filipefurtad0]

Yes, that's it:

as of now, we cannot create/update the variant with empty option

Indeed, this is a mandatory field already before this issue. It should not be possible to remove an attributed unit scale, or create a variant without unit scale.