-
-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Products] Empty option on unit scale dropdown #12969
[Products] Empty option on unit scale dropdown #12969
Conversation
cd6b2ae
to
bafb881
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can see, the include_blank option was added here, perhaps to handle bad data.
Does this mean that every dropdown now has a blank "select unit scale" option? I think it would be ideal if we show "select unit scale" only when data is blank. Is that possible?
@dacook - Sorry this comment skipped my radar. If we want to incorporate this, I don't think it would be much effort. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, it would make more sense if all the drop-downs follow the same behavior? What do you say?
Thanks Ahmed, that's a good point 👍
Let's proceed as-is without adding effort, and if further improvement is needed we can raise an issue to work out the best solution.
Skipping second review as it's a simple change. Ready for testing 🧪 |
Hey @chahmedejaz , I've verified the issue is still present in current master: Creating a new variant displays the empty option on the unit scale dropdown: After this PR
I've tested that this dropdown works otherwise as before: allows changing units for existing variants or creating new variants This looks great 🎉 |
What? Why?
What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):