Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset absent products in Import page does not work #12933

Open
Trementinaire opened this issue Oct 18, 2024 · 8 comments
Open

Reset absent products in Import page does not work #12933

Trementinaire opened this issue Oct 18, 2024 · 8 comments
Assignees
Labels
bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. feedback-needed

Comments

@Trementinaire
Copy link

Description

If I import a product list and I mark "Set stock to zero for all exiting products not present in the file"
imagen

it does not set to zero the products not present in the file imported
imagen

Expected Behavior

set "on hand" to cero

Actual Behaviour

remains last value

Steps to Reproduce

  1. Import product list
  2. check product not in the file
  3. product doesn't set to cero

Workaround

Severity

bug-s2

Your Environment

  • Version used:
  • Browser name and version: Firefox and Chrome
  • Operating System and version (desktop or mobile): Windows 11

Possible Fix

@github-project-automation github-project-automation bot moved this to All the things 💤 in OFN Delivery board Oct 18, 2024
@RachL RachL added the bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. label Oct 24, 2024
@chahmedejaz chahmedejaz self-assigned this Nov 10, 2024
@chahmedejaz chahmedejaz moved this from All the things 💤 to In Progress ⚙ in OFN Delivery board Nov 10, 2024
@chahmedejaz
Copy link
Collaborator

Hi @Trementinaire - I did a spike on this and here are the findings:

  • Only those products are reset to zero stock that are supplied by the producers mentioned in the file
  • For example, you are creating or updating the products by "Farmer A" as producer in the file
  • Only those products are reset to zero stock that is supplied by "Farmer A" if the check is marked
  • Can you please confirm the functionality again and see if you observe the above behavior?

@RachL - I think this functionality is misleading a bit as the checkbox suggests that it would reset all the products regardless of the suppliers mentioned in the file. Please let me know if I'm missing something here. Thanks.

@chahmedejaz chahmedejaz moved this from In Progress ⚙ to Dev ready 👋 in OFN Delivery board Nov 12, 2024
@chahmedejaz chahmedejaz moved this from Dev ready 👋 to All the things 💤 in OFN Delivery board Nov 12, 2024
@Trementinaire
Copy link
Author

Hi @chahmedejaz, I only do it with one supplier. This functionality was working until one and a half month. I see that the products that it does not reset are because there have a negative values in the “on hand” field. May be it can be fixed if this field only accept positive values.

@Trementinaire
Copy link
Author

See this
imagen

@RachL
Copy link
Contributor

RachL commented Nov 14, 2024

@mkllnk maybe this is a regression due to the DFC order stock management work?

@Trementinaire
Copy link
Author

Also I detect too that import create a variant istead of update the product
imagen

@mkllnk
Copy link
Member

mkllnk commented Nov 14, 2024

The screenshot shows a stock level of -30. But I think that you see that only if you untick the on demand box, right?

Until recently, on demand products always had a stock level of zero. So I guess that the product import didn't reset it. But now we do store the number of sold stock in that field. It's usually not visible. I think that we have to update the product import to set stock levels of on-demand products to zero as well.

@mkllnk
Copy link
Member

mkllnk commented Nov 14, 2024

import create a variant istead of update the product

I wonder if that's due to our product refactor work.

@Trementinaire, can you supply CSV files that demonstrate the issue?

@chahmedejaz
Copy link
Collaborator

I think it's this issue maybe 😅:
#12968

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. feedback-needed
Projects
Status: All the things 💤
Development

No branches or pull requests

4 participants