Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin][Order] "Balance due" state after payments with a transaction fee #5574

Closed
filipefurtad0 opened this issue Jun 9, 2020 · 8 comments · Fixed by #12880
Closed

[Admin][Order] "Balance due" state after payments with a transaction fee #5574

filipefurtad0 opened this issue Jun 9, 2020 · 8 comments · Fixed by #12880
Assignees
Labels
bug-s2 The bug is affecting any of the non-critical features described in S1 and there is no workaround.

Comments

@filipefurtad0
Copy link
Contributor

Description

The price shown in backoffice orders does not include transaction fees, for the respective payment methods. After payment is made, there is always an amount still to be charged and the order is in a "balance due" state. Attempting to pay for the open amount leads do an additional charge of the fee.

Expected Behavior

The transaction fee should be included in the total price: it should be updated according to the choices made on Payments section allowing to pay the full price (fee included).

Actual Behaviour

The transaction fee is not included. Paying for orders with transaction fee always renders the order to be in a "balance due" state.

Steps to Reproduce

Admin:

  1. Set up a payment method with a fee.
  2. Start placing an order in the backoffice, inserting items and customer details.
  3. Proceed to Payments and check the total amount to be paid.
  4. Choose the previously set payment method and perform the payment.
  5. Check the state of the order: it should be in "Balance due" with an amount corresponding to the value of the transaction fee.
  6. Attempt to pay this open amount with that payment method - an additional fee will be charged...

Animated Gif/Screenshot

Before payment:
image.png

After payment:
image.png

Workaround

If you know, in advance, what the value of the transaction fee is, then you can add this value manually, as a "prediction" of what the total cost will be. This allows to pay for the total amount with one payment.

Severity

bug-s4: it's annoying, but you can use it

Your Environment

  • Version used: v2.10.0
  • Browser name and version: Firefox 75
  • Operating System and version (desktop or mobile): Desktop Ubuntu 18.04

Possible Fix

@filipefurtad0 filipefurtad0 added the bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. label Jun 9, 2020
@RachL
Copy link
Contributor

RachL commented Jun 9, 2020

@filipefurtad0 I wonder if this isn't a duplicate of: #3490

@filipefurtad0
Copy link
Contributor Author

Hey @RachL ,

I did not see #3490 as a duplicate as it deals with refunds, but it's surely related. Where I really stopped to wonder was this one:

But @lin-d-hop describes a this also from the perspective of performing adjustments, so I didn't consider it as a double either. I thought I'd open this issue despite the pre-existing ones since it describes a straightforward case: no refunds, no adjustments, just a plane backoffice order. Would you agree to keep it, or rather close it?

Also, the root problem seems related to these:

Perhaps addressing the root cause can contribute to solve all of them. Other than cross-mentioning/referring these issues (as above), what would be the best way to group them, so the dev who picks this up is aware of all the implications... Any ideas?

@RachL
Copy link
Contributor

RachL commented Jun 9, 2020

@filipefurtad0 awesome! we could create an epic to group them. Otherwise mentionning and linking them in description is already nice. At least somewhere we document that they might be linked. So you did the right thing of opening a new issue 👍

@github-project-automation github-project-automation bot moved this to All the things in OFN Delivery board Feb 16, 2024
@sigmundpetersen sigmundpetersen changed the title Backoffice orders: "Balance due" state after payments with a transaction fee [Admin][Order] "Balance due" state after payments with a transaction fee May 31, 2024
@amidaOFN
Copy link
Collaborator

We have several reports of this from a key user, and looking at the payment gateway, it is not only that the amount does not display correct, but is not charged correctly either - the lesser amount is charged, so the full transaction fee is not being paid.

@RachL RachL added the bug-s2 The bug is affecting any of the non-critical features described in S1 and there is no workaround. label Aug 29, 2024
@RachL RachL moved this from All the things 💤 to Dev ready 👋 in OFN Delivery board Aug 29, 2024
@RachL RachL removed the bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. label Aug 29, 2024
@rioug rioug self-assigned this Sep 10, 2024
@rioug rioug moved this from Dev ready 👋 to In Progress ⚙ in OFN Delivery board Sep 10, 2024
@rioug
Copy link
Collaborator

rioug commented Sep 10, 2024

@amidaOFN I wasn't able to reproduce the issue. I tried with both a flat fee/percentage fee with a Stripe payment.

Can you confirm it's happening with the described scenario above ? or give more details on the producer set up ?

@rioug
Copy link
Collaborator

rioug commented Sep 25, 2024

Step to reproduce:

  • Set up a Stripe payment method with a fee
  • Start placing an order, selecting the Stripe payment method and stop at Confirmation step
  • Continue shopping by clicking on the shop name next the cart
  • Add or update the quantity of an item
  • Continue checkout, you should land back on the Confirmation step
  • Confirm the order
  • Confirmation page and email should have Balance due equal to the payment fee incurred by the new product or updated quantity

It's actually a problem with order total calculation, and not relate to Stripe. An easier way to reproduce the bug :

  • Set up a Cash payment method with a percentage fee
  • Start placing an order, selecting the Cash payment method and stop at Confirmation step
  • Continue shopping by clicking on the shop name next the cart
  • Add or update the quantity of an item
  • Continue checkout, you should land back on the Confirmation step, note the order total
  • Confirm the order
  • Confirmation page and email should have an order total different from the the one on the Confirmation step.

@rioug
Copy link
Collaborator

rioug commented Sep 25, 2024

Related change #12538, this probably fixed the transaction fee being wrong on the confirmation step in the scenario above.

@drummer83
Copy link
Contributor

The original issue cannot be reproduced anymore. It seems to be fixed already.
The steps pointed out in the comment above are a different issue, described in #12907 now.

Closing here.

@github-project-automation github-project-automation bot moved this from In Progress ⚙ to Done in OFN Delivery board Oct 11, 2024
@rioug rioug reopened this Oct 14, 2024
@github-project-automation github-project-automation bot moved this from Done to Dev ready 👋 in OFN Delivery board Oct 14, 2024
@rioug rioug moved this from Dev ready 👋 to In Progress ⚙ in OFN Delivery board Oct 14, 2024
@github-project-automation github-project-automation bot moved this from In Progress ⚙ to Done in OFN Delivery board Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-s2 The bug is affecting any of the non-critical features described in S1 and there is no workaround.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants