Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adding network edges #93

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[WIP] Adding network edges #93

wants to merge 5 commits into from

Conversation

IAlibay
Copy link
Collaborator

@IAlibay IAlibay commented Jun 12, 2023

Work done in this PR:

TODO:

  • Add star maps (working with @bobym to get a list of cognate ligands)
  • Add mutli-star maps?
  • Other scorers / mappers?

@ijpulidos ijpulidos self-requested a review June 13, 2023 16:52
@ijpulidos
Copy link
Collaborator

ijpulidos commented Jul 5, 2023

From running a single iteration with perses using these edges I'm facing the following problems with eight (8) of the edges:

cdk8/out_18617587_22.stderr:ValueError: could not convert string to float: ' '
eg5/out_18617580_2.stderr:openmmtools.mcmc.IntegratorMoveError: Potential energy is NaN after 20 attempts of integration with move LangevinDynamicsMove
hif2a/out_18617578_12.stderr:openff.toolkit.utils.exceptions.MoleculeParseError: Unable to read molecule from file: ligands.sdf
shp2/out_18617589_13.stderr:perses.rjmc.atom_mapping.InvalidMappingException: Atom mapping contains no mapped atoms
shp2/out_18617589_20.stderr:perses.rjmc.atom_mapping.InvalidMappingException: Atom mapping contains no mapped atoms
shp2/out_18617589_6.stderr:perses.rjmc.atom_mapping.InvalidMappingException: Atom mapping contains no mapped atoms
shp2/out_18617589_8.stderr:openmmtools.mcmc.IntegratorMoveError: Potential energy is NaN after 20 attempts of integration with move LangevinDynamicsMove

I'll be digging into what's making these error out.

@ijpulidos
Copy link
Collaborator

Oh, I just realized that the edges information has atom mapping as key, while I'm not sure this is problematic, we probably want to avoid using spaces here, so we want keys to be atom_mapping instead.

hannahbaumann and others added 2 commits August 8, 2023 09:39
@IAlibay : Dotson merge this now :)
* Add radial networks

* Add networks for 2 Hif2a clusters
* Manually curated edges by Ken Takaba

* better formatting
@dotsdl
Copy link
Member

dotsdl commented Aug 22, 2023

@ijpulidos : can probably finish out this PR next week after review of currently-running benchmarks.

@dotsdl
Copy link
Member

dotsdl commented Aug 29, 2023

From @hannahbaumann: failures in edges may be stemming from poorly-equilibrated starting systems. Can be investigated post-merge of the PR.

@dotsdl
Copy link
Member

dotsdl commented Oct 20, 2023

Any updates on this front? Is anything now blocking this PR?

@IAlibay
Copy link
Collaborator Author

IAlibay commented Oct 20, 2023

I believe it's still in QA last I saw @dotsdl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

4 participants