Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept set when dealing with list of IDs #443

Open
lebaudantoine opened this issue Sep 20, 2023 · 0 comments
Open

Accept set when dealing with list of IDs #443

lebaudantoine opened this issue Sep 20, 2023 · 0 comments
Milestone

Comments

@lebaudantoine
Copy link
Contributor

lebaudantoine commented Sep 20, 2023

Feature Request

Is your feature request related to a problem or unsupported use case? Please describe.
Using the BaseDatabase class, I encountered an issue where I had to convert a set of IDs into a list to match the accepted data type. This conversion seemed unnecessary since sets are more suitable for dealing with unique IDs. Converting a set to a list adds unnecessary overhead, and if possible, we should avoid it to improve efficiency.

This enhancement might be needed elsewhere in the codebase.

Describe the solution you'd like
Enhance the query_statements_by_ids here method's API to allow the relevant data structures for the ids parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants