Modifying settings
on a DataBackend does not update client
#539
Labels
Milestone
settings
on a DataBackend does not update client
#539
Feature Request
Is your feature request related to a problem or an unsupported use case? Please describe.
The public
BaseDataBackend.settings
instance attribute can be modified after backend instantiation.However, once the backend instantiates its
client
property, any changes tosettings
do not updateclient
.Describe the solution you'd like
If changing a backend
settings
attribute after instantiation is a common use case, I think we should track its state from theclient
property and updateclient
in case of a change.Describe alternatives you've considered
Alternatively, we could make
settings
a "read-only" instance attribute to clarify that modifying it might not have the desired impact).Or we could improve our documentation, explaining data backend behavior when
settings
is modified.Discovery, Documentation, Adoption, Migration Strategy
No major impact.
Do you want to work on it through a Pull Request?
Yes, sure, once a consensus is reached on the desired behavior.
Note
Thanks to @Leobouloc for pointing out this issue in #524 (comment)_
The text was updated successfully, but these errors were encountered: