Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename LDP DEFAULT_STREAM_ID setting to STREAM_ID #572

Open
jmaupetit opened this issue Feb 21, 2024 · 1 comment
Open

Rename LDP DEFAULT_STREAM_ID setting to STREAM_ID #572

jmaupetit opened this issue Feb 21, 2024 · 1 comment

Comments

@jmaupetit
Copy link
Contributor

Bug Report

Expected behavior/code

When selecting the ldp backend from the CLI, we expect to be able to set the stream we are targeting with an explicit option name.

Actual Behavior

The --ldp-stream-id does not exist. I suppose Ralph expects this option to be set via the --ldp-default-stream-id option.

Steps to Reproduce

$ ralph list -b ldp --help

Environment

  • Ralph version: 4.1.0
  • Platform: GNU/Linux

Possible Solution
Rename the LDPDataBackendSettings.DEFAULT_STREAM_ID setting to LDPDataBackendSettings.STREAM_ID

@jmaupetit
Copy link
Contributor Author

After IRL discussions with @wilbrdt, the stream ID can also be set via the --target option, which is not explicit. There's room for improvement here.

@jmaupetit jmaupetit added improvement and removed bug labels Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

1 participant