Thing details: Fix config action saves the whole Thing (#2775)

A Thing config action is only supposed to save the config of the Thing, not the whole Thing. Fixes openhab/openhab-core#4380. Signed-off-by: Florian Hotze <[email protected]> (cherry picked from commit d78e6d9)
openhab · Oct 1, 2024 · 6a17c28 · 6a17c28
1 parent 6aa302d
commit 6a17c28
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/bundles/org.openhab.ui/web/src/pages/settings/things/thing-details.vue b/bundles/org.openhab.ui/web/src/pages/settings/things/thing-details.vue
@@ -541,8 +541,6 @@ export default {
       })
     },
     doConfigAction (action) {
-      let thing = this.thing
-      let save = this.save
       if (action.type !== 'BOOLEAN') {
         console.warn('Invalid action type', action)
         return
@@ -558,8 +556,15 @@ export default {
         prompt,
         this.thing.label,
         () => {
-          thing.configuration[action.name] = true
-          save()
+          const name = action.name
+          // Make sure Vue reactivity notices the change
+          this.$set(this.thing, 'configuration', ({
+            name: true,
+            ...this.thing.configuration
+          }))
+          // Vue reactivity is too slow to recognize config change before the API call, manually mark the config dirty
+          this.configDirty = true
+          this.save()
         }
       )
     },