Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: component logic is not good enough #418

Closed
2 tasks done
luhaoling opened this issue Mar 4, 2024 · 0 comments · Fixed by #417
Closed
2 tasks done

Feature: component logic is not good enough #418

luhaoling opened this issue Mar 4, 2024 · 0 comments · Fixed by #417
Labels
feature Categorizes issue or PR as related to a new feature.

Comments

@luhaoling
Copy link
Contributor

Checklist

  • I've searched for similar issues and couldn't find anything matching
  • I've discussed this feature request in the OpenIMSDK Slack and got positive feedback

Is this feature request related to a problem?

None

Problem Description

1、Components are detected successfully and are also detected in the next round
2、No early exit for component detection logic that is not necessary，such as the password wrong
3、not user the tools pkg component check func

Solution Description

reconstruct.

Benefits

Improve efficiency of component inspection.

Potential Drawbacks

No response

Additional Information

No response
@luhaoling luhaoling added the feature Categorizes issue or PR as related to a new feature. label Mar 4, 2024
@luhaoling luhaoling mentioned this issue Mar 4, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix the component check logic to make it better luhaoling/chat
1 participant
@luhaoling