-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: optimize go version auto set #2182
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
label
Apr 15, 2024
openimbot
approved these changes
Apr 15, 2024
kubbot
approved these changes
Apr 15, 2024
OpenIM TestOpenIM API TestCommand Output for OpenIM API Test
OpenIM E2E TestCommand Output for OpenIM E2E Test
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current Makefile restricts the project to specific Go versions: 1.19, 1.20, 1.21, 1.22, and 1.23. This limits the flexibility of the project as Go language versions are forward compatible.
Solution
This PR updates the Makefile to support Go version 1.19 and above. It introduces a new variable GO_MIN_SUPPORTED_VERSION which is set to 1.19. The Makefile now includes a version check that allows compatibility with any Go version greater than or equal t