Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resp #2360

Closed
wants to merge 84 commits into from
Closed

Fix resp #2360

wants to merge 84 commits into from

Conversation

icey-yu
Copy link
Member

@icey-yu icey-yu commented Jun 24, 2024

🅰 Please add the issue ID after "Fixes #"

Fixes #2358
fix: can replace nil in resp

withchao and others added 19 commits June 6, 2024 09:45
# Conflicts:
#	internal/rpc/friend/black.go
#	internal/rpc/friend/callback.go
#	internal/rpc/friend/convert.go
#	internal/rpc/friend/friend.go
#	internal/rpc/friend/notification.go
#	internal/rpc/friend/sync.go
#	internal/rpc/user/user.go
# Conflicts:
#	go.mod
#	go.sum
#	internal/api/router.go
#	internal/rpc/group/sync.go
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 24, 2024
Copy link

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

@icey-yu icey-yu closed this Jun 24, 2024
@openimsdk openimsdk locked and limited conversation to collaborators Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Some slice type in responses will return nil
4 participants