feature: support for Kodo #2363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
printlin
requested review from
Bloomingg,
FGadvancer,
skiffer-git and
withchao
as code owners
pull-request-size
bot
added
the
size/M
|
CLA Assistant Lite bot 🤖 All Contributors have signed the open-im-server CLA. |
|
I have read the CLA Document and I hereby sign the CLA |
openimbot
added a commit
to openim-sigs/cla
that referenced
this pull request
Jun 26, 2024
|
I noticed that the automatic check did not pass because the code for Kodo is not yet included in the tools project. I need to merge the tools project before it can be compiled properly, and I cannot follow up on this error. |
|
Compilation aborted. failed to compile openim-cmdutils for linux_amd64: running "go build -o /home/runner/work/open-im-server/open-im-server/_output/bin/platforms/linux/amd64/openim-cmdutils /home/runner/work/open-im-server/open-im-server/cmd/openim-cmdutils/main.go" failed with exit code 1 |
withchao
approved these changes
Jun 27, 2024
FGadvancer
approved these changes
Jul 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I mentioned in [#1923 ], the support library for Qiniu Kodo has not been merged properly. I noticed that the project structure has changed and the code related to S3 has been moved to the Tools project. I have completed these changes and also submitted PR in the tools project.
Fixes #
#1923