-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRE REVIEW]: PyKoopman: A Python Package for Data-Driven Approximation of the Koopman Operator #5574
Comments
Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
@pswpswpsw - thanks for your submission. Please remove items in your bib file that aren't actually cited in your paper, as our checker looks through the whole bib file. Please feel free to make changes to your .bib file, then use the command Once you have done this, you could work on any possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. Once this is done, use the command |
I'm also not sure why your paper is not generating, so I'll try the command here. |
@editorialbot generate pdf |
Note that your paper does not compile. Please follow the example paper and note that you can click on the error above to find out more about it. There, I see "Problem with affiliations for Shaowu Pan, perhaps the affiliations index need quoting? (Theoj::Error)" Please use the command |
Hi Daniel,
Sorry for the trouble. I generate PDF from my end with the following
command.
pandoc -s --bibliography paper.bib --citeproc paper.md --csl default.csl
-o paper.pdf
I will go back to cut the reference bib.
Best,
==========
Shaowu Pan
Assistant Professor of Aerospace Engineering
Rensselaer Polytechnic Institute
…On Tue, Jun 20, 2023 at 2:17 PM Daniel S. Katz ***@***.***> wrote:
I'm also not sure why your paper is not generating, so I'll try the
command here.
—
Reply to this email directly, view it on GitHub
<#5574 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB4ZAOHYU4SDHKASYOGLBYDXMHSNPANCNFSM6AAAAAAZNUYJDA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Got it. I will fix the issue by quoting it. And I will try again with the
github action.
Best,
==========
Shaowu Pan
Assistant Professor of Aerospace Engineering
Rensselaer Polytechnic Institute
…On Tue, Jun 20, 2023 at 2:20 PM Daniel S. Katz ***@***.***> wrote:
Note that your paper does not compile. Please follow the example paper
<https://joss.readthedocs.io/en/latest/submitting.html#example-paper-and-bibliography>
and note that you can click on the error above to find out more about it.
There, I see "Problem with affiliations for Shaowu Pan, perhaps the
affiliations index need quoting? (Theoj::Error)"
Please use the command @editorialbot generate pdf after making changes to
the .md file to make a new PDF. editorialbot commands need to be the first
entry in a new comment.
—
Reply to this email directly, view it on GitHub
<#5574 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB4ZAOF6QJWGRH2RDVDVPKLXMHSV3ANCNFSM6AAAAAAZNUYJDA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@editorialbot generate pdf |
@danielskatz thanks Daniel for the tip. Now it passes the PDF test. What to do next? |
@danielskatz Yes. I have called the bot to generate the PDF. It shows up here
|
@editorialbot check references |
@editorialbot commands |
Hello @pswpswpsw, here are the things you can ask me to do:
|
|
I see. I will fill up all the missing DOIs |
@editorialbot check references |
|
@editorialbot generate pdf |
Thanks @pswpswpsw |
@olexandr-konovalov - Do you think you would be able to edit this submission? |
@editorialbot invite @olexandr-konovalov as editor |
Invitation to edit this submission sent! |
👋 @olexandr-konovalov - ping (re above invitation to edit) |
@editorialbot assign @olexandr-konovalov as editor |
Assigned! @olexandr-konovalov is now the editor |
@pswpswpsw @danielskatz will be happy to be an editor, thanks - will however not be able to deal with this until the 3rd week of July. |
@pswpswpsw @danielskatz sorry it took a while over the summer - I will try to deal with it now in August. |
Thanks!
Best,
==========
Shaowu Pan
Assistant Professor of Aerospace Engineering
Rensselaer Polytechnic Institute
…On Mon, Aug 14, 2023 at 4:42 AM Olexandr Konovalov ***@***.***> wrote:
@pswpswpsw <https://github.com/pswpswpsw> @danielskatz
<https://github.com/danielskatz> sorry it took a while over the summer -
I will try to deal with it now in August.
—
Reply to this email directly, view it on GitHub
<#5574 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB4ZAOBAAA5CBWBVL4DFCVTXVHQGZANCNFSM6AAAAAAZNUYJDA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@olexandr-konovalov - any news? I think the current step is finding reviewers. |
@ulf1 @SichengHe would one or both of you be able to review this submission for JOSS, please? If not, could you possibly recommend someone whom we may approach regarding this? |
@fandreuz @ndem0 @sichinaga @mtezzele I am contacting you as main developers of PyDMD - would one of you be willing and able to review this submission for JOSS, please? If you haven't reviewed for JOSS before, here we have the Reviewer Guidelines. |
@danielskatz @olexandr-konovalov I have time to review it |
@ulf1 many thanks! I will start the review when the 2nd reviewer will be known. |
Hi @olexandr-konovalov, I'm also available to review this submission. |
@editorialbot add @ulf1 as reviewer |
@ulf1 added to the reviewers list! |
@editorialbot add @fandreuz as reviewer |
@fandreuz added to the reviewers list! |
@editorialbot start review |
OK, I've started the review over in #5881. |
Submitting author: @pswpswpsw (Shaowu Pan)
Repository: https://github.com/dynamicslab/pykoopman
Branch with paper.md (empty if default branch):
Version: v1.0.3
Editor: @olexandr-konovalov
Reviewers: @ulf1, @fandreuz
Managing EiC: Daniel S. Katz
Status
Status badge code:
Author instructions
Thanks for submitting your paper to JOSS @pswpswpsw. Currently, there isn't a JOSS editor assigned to your paper.
@pswpswpsw if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.
Editor instructions
The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:
The text was updated successfully, but these errors were encountered: